Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding buttons to the Page header #58

Closed
lottamus opened this issue Sep 24, 2019 · 1 comment
Closed

Allow adding buttons to the Page header #58

lottamus opened this issue Sep 24, 2019 · 1 comment

Comments

@lottamus
Copy link
Contributor

lottamus commented Sep 24, 2019

In https://github.com/stoplightio/app-gen3/issues/399 we want to be able to use the Page component but its currently missing support for adding buttons.

Suggest updating the Page component to look something like this:

export interface IPage extends IErrorBoundary {
  type: NodeType;
  data: any;

  name?: string;
  srn?: string;
  version?: string;
  versions?: string[];

  headerRight?: React.FunctionComponent

  padding?: string;
  className?: string;
  shadows?: boolean;
  scrollInnerContainer?: boolean;
}

We will also need to support adding these buttons via the Page container too:

export interface IPage {

Explorer___Stoplight

@lottamus
Copy link
Contributor Author

Let's render the buttons above the Page component inside of Explorer rather than passing them into the Page for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants