fix: bump json-schema-viewer and json-schema-tree version #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendarearden
force-pushed
the
fix/2419-sibling-examples-ref
branch
from
e3b9ea9
to
df9d8bc
Compare
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mallachari
approved these changes
Dec 14, 2023
|
Don't you want to release that package too? |
brendarearden
force-pushed
the
fix/2419-sibling-examples-ref
branch
from
d300655
to
bb5e7ae
Compare
|
Release looks good too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elements Default PR Template
In general, make sure you have: (check the boxes to acknowledge you've followed this template)
CONTRIBUTING.mdOther Available PR Templates:
CONTRIBUTING.mdFixes: #2419
When resolving references in an allOf, if the reference had a description or summary sibling, it was getting overwritten by the description or summary in the referenced object, if the same key existed. Starting in OAS 3.1, description and summary became supported reference siblings.
This PR bumps versions of packages that have been updated to not overwrite description and summary ref siblings for allOf objects to stay inline with OAS 3.1
Image from modified static-html app with the latest version bumps using a modified version of the OAS file provided in the reported issue :
