fix: callback operation header #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mallachari
requested review from
P0lip,
a team,
brendarearden and
matthewmurphy
and removed request for
a team and
P0lip
matthewmurphy
approved these changes
Dec 20, 2023
packages/elements-core/src/components/Docs/HttpOperation/Callbacks.tsx
Outdated
Show resolved
Hide resolved
…acks.tsx Co-authored-by: Daniel A. White <daniel.white@smartbear.com>
daniel-white
approved these changes
Dec 21, 2023
brendarearden
approved these changes
Dec 21, 2023
mallachari
force-pushed
the
fix/callback-operation-header
branch
from
22efb19
to
4da75fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: https://github.com/stoplightio/platform-internal/issues/18498
Within callbacks we don't want to show base url from parent operation. Since callback path usually comes with full url, either as runtime expression or static url, we want to show only path.
This PR adds an optional property
hideServerUrltoOperationHeaderandMethodPathand sets it to true forCallbackcomponent.Path as runtime expression:
Static path:
