New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAS3 integration tests and fixes SO-103 #253
Conversation
5f0c6d3
to
a9aed0e
Compare
24a19a0
to
b8ac931
Compare
1c1a01e
to
30999c6
Compare
11d1610
to
49c68e4
Compare
@philsturgeon I've gone ahead, unified the two documents (oas2 and 3) and used the same test assertions; then I wrote the required specific assertions for oas3. Moreover, while writing these tests I literally lost 2-3 hours in understanding a subtle bug I was not able to track — ultimately it turn out that since the graphite instances created by the loaders for Prism are singleton, when loading a different file even though creating a new Prims instance the new resources get stacked up on top of the last loaded ones — basically creating a whole |
6eeb56c
to
5e83a3c
Compare
07577cd
to
d459ca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yo, good job Vincenzo! Prism it starting to look great again :)
I have only few small comments.
d6dc96f
to
088d6d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
noEmit
flag for typechecks in CI so checks time halves.