Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): correctly handle special characters in JUnit failure details #2028

Merged
merged 5 commits into from
Jan 20, 2022
Merged

fix(cli): correctly handle special characters in JUnit failure details #2028

merged 5 commits into from
Jan 20, 2022

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Jan 19, 2022 •
edited

Those details are contained in XML CDATA section and should therefore not be XML-escaped.

Fixes #2027

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

🛠 with ❤ at Siemens

@fgreinacher fgreinacher marked this pull request as ready for review January 19, 2022 08:36
@fgreinacher
fix(cli): correctly handle special characters in JUnit failure details
ffc1c1e 
Those details are contained in XML CDATA section and should therefore not be XML-escaped.
@fgreinacher
Copy link
Contributor Author

fgreinacher commented Jan 20, 2022 •
edited

Harness tests adapted in 6807c2d 😀

P0lip
P0lip previously approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@P0lip P0lip enabled auto-merge (squash) January 20, 2022 17:07
@P0lip P0lip added the t/bug Something isn't working label Jan 20, 2022
@P0lip P0lip merged commit cabd2a9 into stoplightio:develop Jan 20, 2022
@fgreinacher fgreinacher deleted the fix/cdata-escape branch January 20, 2022 17:10
@fgreinacher
Copy link
Contributor Author

fgreinacher commented Jan 21, 2022 •
edited

@P0lip Do you already have a plan for a new release? We are keen to try this out - in the best case together with #2011 and #1970 - without ugly workarounds 😀

@P0lip
Copy link
Contributor

P0lip commented Jan 21, 2022

@fgreinacher we have a daily release cronjob that runs at around 2pm CET, so your changes should be released within a few hours.

@fgreinacher
Copy link
Contributor Author

fgreinacher commented Jan 21, 2022 •
edited

Awesome, thanks @P0lip. I was a bit confused because there has not been a GitHub release for a long time. But I guess you just don't create releases anymore after switching to a monorepo setup, so all good!

@P0lip
Copy link
Contributor

P0lip commented Jan 21, 2022

There'll be comments posted on your issues once the code is out.
We create Github Releases only for the CLI package, and indeed there wasn't any release since October or so.
npm picks up the latest version of each Spectral package anyway, so it's mostly Docker images & Binaries that are lagging behind.

stoplight-bot pushed a commit that referenced this pull request Jan 21, 2022
@StoplightSupport
chore(release): 6.1.1 [skip ci]
d724c17 
# [@stoplight/spectral-cli-v6.1.1](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-cli-v6.1.0...@stoplight/spectral-cli-v6.1.1) (2022-01-21)

### Bug Fixes

* **cli:** add path to JUnit testcase name ([#2029](#2029)) ([062ae0c](062ae0c))
* **cli:** correctly handle special characters in JUnit failure details ([#2028](#2028)) ([cabd2a9](cabd2a9))
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-cli-v6.1.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P0lip P0lip P0lip approved these changes

Assignees
No one assigned
Labels
released t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JUnit formatter incorrectly escapes failure details
3 participants
@fgreinacher @P0lip @stoplight-bot