Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear out old TS rules and functions #561

Closed
5 of 7 tasks
philsturgeon opened this issue Sep 17, 2019 · 5 comments
Closed
5 of 7 tasks

Clear out old TS rules and functions #561

philsturgeon opened this issue Sep 17, 2019 · 5 comments
Labels
breaking Pull requests that introduce a breaking change help wanted Extra attention is needed p/medium tech-debt

Comments

@philsturgeon
Copy link
Contributor

philsturgeon commented Sep 17, 2019

Go on a delete-spree taking away all of the old TS ruleset stuff.

  • Spectral.addRules()
  • Spectral.addFunctions()
  • src/rulesets/oas/index.ts
  • src/rulesets/oas2/index.ts
  • src/rulesets/oas3/index.ts
  • src/types/rule.ts
  • anything else?

Whenever this gets done, it means the next release will need to be v5.0.

@philsturgeon philsturgeon transferred this issue from stoplightio/prism Sep 17, 2019
@philsturgeon philsturgeon added this to the Oct '19 milestone Sep 17, 2019
@philsturgeon philsturgeon added the breaking Pull requests that introduce a breaking change label Oct 1, 2019
@philsturgeon philsturgeon added help wanted Extra attention is needed p/medium tech-debt labels Oct 15, 2019
@philsturgeon
Copy link
Contributor Author

@nulltoken if you want to start nuking bits I would really appreciate that. It would solve the confusion in #677.

@nulltoken
Copy link
Contributor

@philsturgeon Let me see what I can come up with.

@nulltoken nulltoken mentioned this issue Oct 16, 2019
7 tasks
@nulltoken
Copy link
Contributor

nulltoken commented Oct 16, 2019

@philsturgeon Let me see what I can come up with.

So... I've started to chew on #689. It may not cover all the scope of this issue but should definitely hit "the one ruleset to rule them all" topic from #677 (comment) (in a backward compatible way).

To start with, I'm going to learn a bit from the failing tests that are going to break. Then I might ping @P0lip when I've got a rough proposal of what I'd like to propose.

@P0lip
Copy link
Contributor

P0lip commented Oct 16, 2019

Then I might ping @P0lip when I've got a rough proposal of what I'd like to propose.

Sure thing @nulltoken. As always, I'm happy to help. :)
LMK once you have anything you'd like to share. Good luck!
Huge thanks for your contribution. ❤️

@P0lip
Copy link
Contributor

P0lip commented Dec 2, 2019

Done in #773

@P0lip P0lip closed this as completed Dec 2, 2019
@P0lip P0lip removed this from the Oct '19 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Pull requests that introduce a breaking change help wanted Extra attention is needed p/medium tech-debt
Projects
None yet
Development

No branches or pull requests

3 participants