chore: remove addRules and addFunctions #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
force-pushed
the
feat/remove-add-rules-functions
branch
from
878a9e4
to
b56fb6c
Compare
| @@ -18,6 +18,7 @@ rules: | |||
| function: truthy | |||
| ``` | |||
|
|
|||
| Spectral has a built-in set of functions which you can reference in your rules. This example uses the `truthy` to create a rule that checks that the value is true. | |||
| The example above adds a single rule that checks that tags objects have a description property defined. | |||
There was a problem hiding this comment.
"The example above" sounds a little funny now as we already say "This example". Can you merge the two sentences to make it less redundant?
There was a problem hiding this comment.
Yeah, you are right. It does sounds awkward. Will merge
philsturgeon
previously approved these changes
Oct 28, 2019
philsturgeon
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #695
Addresses parts of #561
Checklist
Does this PR introduce a breaking change?