Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oas-valid-example): ignore externalValue #1379

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Oct 9, 2020

Fixes #1349

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added the t/bug Something isn't working label Oct 9, 2020
@P0lip P0lip self-assigned this Oct 9, 2020
@P0lip P0lip merged commit e1a0d46 into develop Oct 9, 2020
@P0lip P0lip deleted the fix/ignore-external-value branch October 9, 2020 14:20
@mediavrog
Copy link

mediavrog commented Oct 15, 2020

Thanks a bunch for adding this fix and in general providing such a useful tool!
Is there an estimate when this fix will be released, as currently our github actions relying on spectral report errors on our schema. Any upcoming milestone?

For now we will use 5.3.0 so it is not urgent

@philsturgeon
Copy link
Contributor

@P0lip we've acrued a fair few fixes now, can we knock out a 5.6.1 this week?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oas3-valid-oas-content-example should support or ignore externalValue
3 participants