Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(installer): support for alpine linux #1512

Merged
merged 4 commits into from Feb 21, 2021

Conversation

doshidhaval
Copy link
Contributor

@doshidhaval doshidhaval commented Feb 20, 2021

Fixes #1374.

Checklist

  • Tests added / updated - N/A
  • Docs added / updated - N/A

Does this PR introduce a breaking change?

  • Yes
  • No

Additional context
Implemented the fix based on @DenialAdams suggestion
Tested on Alpine Linux container, need to install the following packages for spectral to work on alpine

apk add libstdc++
apk add libgcc

Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename is incorrect.
Otherwise looks good.

scripts/install.sh Outdated Show resolved Hide resolved
@P0lip P0lip merged commit 85c7a9b into stoplightio:develop Feb 21, 2021
@P0lip
Copy link
Contributor

P0lip commented Feb 21, 2021

Thanks for the PR!

@doshidhaval doshidhaval deleted the build/alpine-installer branch February 21, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants