fix(core): fixed jsonpath exprs may occasionally yield incorect results #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
commented
Oct 27, 2021
| @@ -32,13 +32,13 @@ | |||
| "ajv-errors": "~3.0.0", | |||
| "ajv-formats": "~2.1.0", | |||
| "blueimp-md5": "2.18.0", | |||
| "expression-eval": "4.0.0", | |||
There was a problem hiding this comment.
expression-eval uses an older version of jsep
There's a PR there that adds newer jsep, but until it's merged we can use simple-eval which does roughly the same.
It's my library tho, but it's very small. Here's pretty much the entire code https://github.com/P0lip/simple-eval/blob/master/src/reduce.mj
P0lip
commented
Oct 27, 2021
| './__karma__/**/*.ts': ['karma-typescript'], | ||
| }, | ||
|
|
||
| // @ts-expect-error: non-standard - karma-env-preprocessor | ||
| envPreprocessor: ['USE_NIMMA'], |
There was a problem hiding this comment.
this ENV var is no longer used, should have been deleted long ago.
domagojk
approved these changes
Nov 3, 2021
stoplight-bot
pushed a commit
that referenced
this pull request
Nov 4, 2021
# [@stoplight/spectral-core-v1.6.1](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-core-v1.6.0...@stoplight/spectral-core-v1.6.1) (2021-11-04) ### Bug Fixes * **core:** fixed jsonpath expressions may occasionally yield incorect results ([#1917](#1917)) ([1a5a227](1a5a227))
|
🎉 This PR is included in version @stoplight/spectral-core-v1.6.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1910
Checklist
Does this PR introduce a breaking change?
Interesting changes