fix(ruleset-bundler): improve package import heuristics #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
commented
Dec 2, 2021
| const path = id.split('/'); | ||
|
|
||
| if (path.length > 0 && isValidPackageName(path[0])) { | ||
| if (isPackageImport(id)) { |
There was a problem hiding this comment.
should be safe, I already account for a variety of situations
https://github.com/stoplightio/spectral/blob/0ae8242f8ec6e36c4876f47aca27ac7bf4022261/packages/ruleset-bundler/src/plugins/__tests__/skypack.spec.ts
P0lip
requested review from
a team and
jgreen44
and removed request for
a team
domagojk
approved these changes
Dec 10, 2021
stoplight-bot
pushed a commit
that referenced
this pull request
Dec 10, 2021
# [@stoplight/spectral-ruleset-bundler-v1.0.1](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-bundler-v1.0.0...@stoplight/spectral-ruleset-bundler-v1.0.1) (2021-12-10) ### Bug Fixes * **ruleset-bundler:** improve package import heuristics ([#1985](#1985)) ([5c013e9](5c013e9))
|
🎉 This PR is included in version @stoplight/spectral-ruleset-bundler-v1.0.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised on our Discord https://discord.com/channels/841794018173648916/859895506271600670/916069211405705246
Checklist
Does this PR introduce a breaking change?