Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ruleset-bundler): a number of minor enhancements #2048

Merged
merged 4 commits into from
Feb 25, 2022

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Feb 3, 2022

Related to https://github.com/stoplightio/platform-internal/pull/7403

This is an accumulated set of changes I've kept track of after the initial release of the package and the actual integrations attempts in Studio and Spectral CLI.
I suggest reviewing this PR commit by commit because each change is somewhat different.

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added the enhancement New feature or request label Feb 3, 2022
@P0lip P0lip self-assigned this Feb 3, 2022
@P0lip P0lip force-pushed the feat/ruleset-bundler/number-of-imprs branch from 35967ec to 980ea09 Compare February 7, 2022 07:04
@P0lip P0lip force-pushed the feat/ruleset-bundler/number-of-imprs branch 4 times, most recently from 14947c9 to fea1e4b Compare February 14, 2022 19:42
@P0lip P0lip marked this pull request as ready for review February 14, 2022 19:46
@P0lip P0lip requested a review from a team February 14, 2022 19:47
@P0lip P0lip enabled auto-merge (rebase) February 14, 2022 19:48
Comment on lines +1 to +5
// this function makes sure we can only have one plugin with the same name
// the last plugin definition has a precedence
import type { Plugin } from 'rollup';

export function dedupeRollupPlugins(plugins: Plugin[]): Plugin[] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 very nice

@P0lip P0lip force-pushed the feat/ruleset-bundler/number-of-imprs branch from fea1e4b to 402da89 Compare February 17, 2022 15:28
@P0lip P0lip disabled auto-merge February 21, 2022 13:34
@P0lip P0lip force-pushed the feat/ruleset-bundler/number-of-imprs branch from 402da89 to 210f80f Compare February 21, 2022 13:34
@P0lip P0lip requested a review from marbemac February 21, 2022 13:47
@P0lip P0lip enabled auto-merge (rebase) February 21, 2022 13:47
marbemac
marbemac previously approved these changes Feb 25, 2022
Copy link
Contributor

@marbemac marbemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@P0lip P0lip force-pushed the feat/ruleset-bundler/number-of-imprs branch from 317ade9 to 7c3f03f Compare February 25, 2022 19:22
@P0lip P0lip disabled auto-merge February 25, 2022 19:29
@P0lip P0lip merged commit b06903c into develop Feb 25, 2022
@P0lip P0lip deleted the feat/ruleset-bundler/number-of-imprs branch February 25, 2022 19:29
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-ruleset-bundler-v1.2.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants