Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rulesets): simplify schema used in duplicated-entry-in-enum #2055

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Feb 10, 2022

Related to #2052

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip self-assigned this Feb 10, 2022
@@ -123,22 +123,14 @@ const ruleset = {
severity: 'warn',
recommended: true,
message: '{{error}}',
given: '$..enum',
given: ["$..[?(@property !== 'properties' && @ && @.enum)]"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a better world, this would be just #SchemaObject.
Soon.

@P0lip P0lip marked this pull request as ready for review February 10, 2022 14:21
@P0lip P0lip requested a review from a team February 10, 2022 14:21
@P0lip P0lip enabled auto-merge (squash) February 11, 2022 12:08
@P0lip P0lip merged commit 8451774 into develop Feb 11, 2022
@P0lip P0lip deleted the fix/rulesets/duplicated-entry-in-enum branch February 11, 2022 12:11
stoplight-bot pushed a commit that referenced this pull request Feb 14, 2022
# [@stoplight/spectral-rulesets-v1.4.3](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-rulesets-v1.4.2...@stoplight/spectral-rulesets-v1.4.3) (2022-02-14)

### Bug Fixes

* **rulesets:** simplify schema used in duplicated-entry-in-enum ([#2055](#2055)) ([8451774](8451774))
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-rulesets-v1.4.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants