Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rulesets): support AsyncAPI 2.4 #2146

Merged
merged 1 commit into from May 2, 2022
Merged

feat(rulesets): support AsyncAPI 2.4 #2146

merged 1 commit into from May 2, 2022

Conversation

jonaslagoni
Copy link
Collaborator

Fixes #2145

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@jonaslagoni jonaslagoni requested review from magicmatatjahu, smoya and a team as code owners May 2, 2022 08:52
@P0lip
Copy link
Contributor

P0lip commented May 2, 2022

Ah, it's the CI check again.
There's something off with the fork

@P0lip P0lip merged commit 4332508 into stoplightio:develop May 2, 2022
@jonaslagoni jonaslagoni deleted the feature/support_asyncapi_2_4 branch May 2, 2022 20:42
P0lip added a commit that referenced this pull request May 2, 2022
@P0lip
feat(formats): support AsyncAPI 2.4 (#2146)
ca15966
@jonaslagoni
Copy link
Collaborator Author

Ah, it's the CI check again.
There's something off with the fork

Anything you know I need to change? Or should I just start using the branches in stoplightio/spectral instead 😆

P0lip pushed a commit that referenced this pull request May 2, 2022
@jonaslagoni @P0lip
feat(formats): support AsyncAPI 2.4 (#2146)
8b5d6b3
stoplight-spectral-bot pushed a commit that referenced this pull request May 2, 2022
@StoplightSupport
chore(release): 1.2.0 [skip ci]
06c52b4 
# [@stoplight/spectral-formats-v1.2.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-formats-v1.1.0...@stoplight/spectral-formats-v1.2.0) (2022-05-02)

### Features

* **formats:** support AsyncAPI 2.4 ([#2146](#2146)) ([8b5d6b3](8b5d6b3))
P0lip pushed a commit that referenced this pull request May 2, 2022
@jonaslagoni @P0lip
feat(rulesets): support AsyncAPI 2.4 (#2146)
eb17502
P0lip pushed a commit that referenced this pull request May 2, 2022
@jonaslagoni @P0lip
feat(rulesets): support AsyncAPI 2.4 (#2146)
7364b2d
@P0lip
Copy link
Contributor

P0lip commented May 3, 2022

ing you know I need to change? Or should I just start using the branches in stoplightio/spectral instead 😆

No clue, I'd probably need to reach out to CircleCI. That issue isn't specific to Spectral, it happens to some forks of stoplightio/prism as well.
Nonetheless, you can indeed push straight onto stoplightio/spectral :)

@jonaslagoni
Copy link
Collaborator Author

No clue, I'd probably need to reach out to CircleCI. That issue isn't specific to Spectral, it happens to some forks of stoplightio/prism as well.
Nonetheless, you can indeed push straight onto stoplightio/spectral :)

Alright, I am gonna do that going forward then 🙂 Thanks!

stoplight-spectral-bot pushed a commit that referenced this pull request May 3, 2022
@StoplightSupport
chore(release): 1.8.0 [skip ci]
e6a90f2 
# [@stoplight/spectral-rulesets-v1.8.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-rulesets-v1.7.0...@stoplight/spectral-rulesets-v1.8.0) (2022-05-03)

### Features

* **rulesets:** support AsyncAPI 2.4 ([#2146](#2146)) ([7364b2d](7364b2d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P0lip P0lip P0lip approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@smoya smoya Awaiting requested review from smoya smoya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for AsyncAPI 2.4
2 participants
@jonaslagoni @P0lip