Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): choose proxy agent based on requester protocol #2521

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Aug 2, 2023

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Side note - in the next major release, we should prob align Spectral (and the rest of our tooling) with a more common implementation that relies on HTTP_PROXY, HTTPS_PROXY and NO_PROXY.

@P0lip P0lip requested a review from mnaumanali94 August 2, 2023 13:47
@P0lip P0lip self-assigned this Aug 2, 2023
@P0lip P0lip requested a review from a team as a code owner August 2, 2023 13:47
@P0lip P0lip merged commit 056f2e1 into develop Aug 4, 2023
9 checks passed
@P0lip P0lip deleted the fix/cli/choose-proxy-based-on-protocol branch August 4, 2023 08:23
stoplight-bot pushed a commit that referenced this pull request Aug 4, 2023
## @stoplight/spectral-cli [6.10.1](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-cli-6.10.0...@stoplight/spectral-cli-6.10.1) (2023-08-04)

### Bug Fixes

* **cli:** choose proxy agent based on requester protocol ([#2521](#2521)) ([056f2e1](056f2e1))
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 6.10.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants