Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(schema): improve enum validation #579

Merged
merged 4 commits into from Sep 23, 2019
Merged

feat(schema): improve enum validation #579

merged 4 commits into from Sep 23, 2019

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Sep 20, 2019 •
edited

A follow-up PR for #576 (comment)

Blocked by atlassian/better-ajv-errors#62

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added the enhancement New feature or request label Sep 20, 2019
@P0lip P0lip self-assigned this Sep 20, 2019
@P0lip P0lip force-pushed the feat/nicer-enum-validation branch 2 times, most recently from 065a462 to 98c5212 Compare September 20, 2019 20:01
@P0lip P0lip marked this pull request as ready for review September 21, 2019 17:51
marbemac
marbemac previously approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@marbemac marbemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍looks nice

philsturgeon
philsturgeon approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great little change! It's the little details like this that get people excited about software! :D

@P0lip P0lip merged commit 12ca287 into develop Sep 23, 2019
@P0lip P0lip deleted the feat/nicer-enum-validation branch September 23, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philsturgeon philsturgeon philsturgeon approved these changes

@marbemac marbemac marbemac left review comments

Assignees

@P0lip P0lip

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@P0lip @philsturgeon @marbemac