Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alphabetical): improve validation results #613

Merged
merged 3 commits into from Sep 30, 2019
Merged

feat(alphabetical): improve validation results #613

merged 3 commits into from Sep 30, 2019

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Sep 30, 2019

There are 3 major changes:

  • no sorting - it's not really needed
  • better paths are reported
  • names of properties to be sorted are included in the message

@P0lip P0lip added the enhancement New feature or request label Sep 30, 2019
@P0lip P0lip self-assigned this Sep 30, 2019
marbemac
marbemac approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@marbemac marbemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@P0lip P0lip merged commit d019111 into develop Sep 30, 2019
@P0lip P0lip deleted the perf/alphabetical branch September 30, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marbemac marbemac marbemac approved these changes

@philsturgeon philsturgeon Awaiting requested review from philsturgeon

Assignees

@P0lip P0lip

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@P0lip @marbemac