fix(resolving): detect the source of local references properly #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, some weird issue with bundling 🤔 |
P0lip
force-pushed
the
fix/refs-sources
branch
from
28f8b65
to
5fc81e9
Compare
P0lip
force-pushed
the
fix/refs-sources
branch
from
5fc81e9
to
6986b82
Compare
marbemac
approved these changes
Oct 2, 2019
| @@ -48,12 +72,12 @@ export class Resolved { | |||
|
|
|||
| if (target && target[REF_METADATA]) { | |||
| return { | |||
| path: [...get(target, [REF_METADATA, 'root'], []), ...newPath], | |||
| path: [...get(target, [REF_METADATA, 'root'], []).map(decodePointerFragment), ...newPath], | |||
There was a problem hiding this comment.
Why is decodePointerFragment required now?
There was a problem hiding this comment.
So the path stored under get(target, [REF_METADATA, 'root'] is escaped, meaning /foo is represented as ~1foo.
The path we expect to return should be unescaped (/foo), so that the YAML/JSON getLocationForJsonPath can find a node correctly.
If you revert the change, the test I added will fail - produced ranges will be less precise (they will point at paths rather than paths//test/get.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #572 (comment) and a potential issue (see 28f8b65)
Checklist
Does this PR introduce a breaking change?