Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule to detect operation tags that are not defined in global tags object #704

Merged
merged 4 commits into from Oct 24, 2019

Conversation

mkistler
Copy link
Contributor

This PR adds a new operation validation that reports operation tag values that are not defined in the global tags array.

This new rule is marked as "recommended" and by default produces a warning message.

  • Tests added / updated
  • [?] Docs added / updated

Note: "CONTRIBUTING.md" does not say anything about doc updates, so I'm not quite sure what I need to do there.

Does this PR introduce a breaking change?

  • Yes
  • No

@philsturgeon
Copy link
Contributor

This is great @mkistler! The docs mention is just a reminder to get people to see if anything in docs/ needs updating, maybe the OpenAPI reference docs: https://github.com/stoplightio/spectral/tree/develop/docs/reference

Tests are failing for some reason, but if you get them passing and docs added I'll hit merge on this thing!

@philsturgeon philsturgeon merged commit 846e8d1 into stoplightio:develop Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants