fix: resolve the source of errors for top-level references #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a cherry-pick of the fix originally provided in 05e909d. Since it's unrelated, let's merge it ASAP, while I'm addressing the comments regarding the actual part of that PR. Will also reduce the noise in that PR making it easier to review.
Checklist
Does this PR introduce a breaking change?
Additional context
Minor fix for top-level $refs. Right now, the source of error would not always be detected correctly for such a document
Rather unlikely to be an often case, but it's still good detect it correctly.