remove more unneeded things, add checks to ensure things are not called

\n(feature/161_handle_failure_if_branch_not_pushed)

tests/test_dev.py

@@ -3,7 +3,6 @@
 import click.testing
 import git
 import tests.conftest as conftest
-import pathlib
 import pytest
 import webbrowser
 import zazu.cli
@@ -266,7 +265,6 @@ def test_review_push_fails(mocker, git_repo):
     mocked_reviewer.review = mocker.Mock(return_value=[])
     mocked_reviewer.create_review = mocker.Mock()
     mocker.patch('zazu.config.Config.code_reviewer', return_value=mocked_reviewer)
-    mocker.patch('zazu.util.prompt', side_effect=['title', 'summary'])
     with zazu.util.cd(git_repo.working_tree_dir):
         runner = click.testing.CliRunner()
         result = runner.invoke(zazu.cli.cli, ['dev', 'review'])
@@ -276,19 +274,14 @@ def test_review_push_fails(mocker, git_repo):
 
 
 def test_review_dirty_working_tree(mocker, git_repo_with_local_origin, tmp_dir):
-    mocker.patch('webbrowser.open_new')
-    mocked_tracker = mocker.Mock()
-    mocked_tracker.issue = mocker.Mock(side_effect=zazu.issue_tracker.IssueTrackerError)
     mocked_reviewer = mocker.Mock()
     mocked_reviewer.review = mocker.Mock(return_value=[])
     mocked_reviewer.create_review = mocker.Mock()
-    mocker.patch('zazu.config.Config.issue_tracker', return_value=mocked_tracker)
-    mocker.patch('zazu.config.Config.code_reviewer', return_value=mocked_reviewer)
-    mocker.patch('zazu.util.prompt', side_effect=['title', 'summary'])
-    pathlib.Path(tmp_dir).joinpath('un-tracked_file.txt').touch()
+    with open('un-tracked_file.txt', 'w') as f: pass
     with zazu.util.cd(git_repo_with_local_origin.working_tree_dir):
         runner = click.testing.CliRunner()
         result = runner.invoke(zazu.cli.cli, ['dev', 'review'])
+        assert not mocked_reviewer.called
         assert result.exception
         assert result.exit_code == 1