feat: ucan stream handles receipts #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View stack outputs
|
vasco-santos
force-pushed
the
feat/ucan-stream-handle-receipts
branch
from
45543c0
to
e7bf749
Compare
vasco-santos
commented
Mar 23, 2023
| @@ -189,8 +189,17 @@ export function UcanInvocationStack({ stack, app }) { | |||
| deadLetterQueue: spaceMetricsDLQ.cdk.queue, | |||
| }) | |||
|
|
|||
| // TODO: keep for historical content that we might want to process | |||
There was a problem hiding this comment.
alanshaw
approved these changes
Mar 23, 2023
olizilla
reviewed
Mar 23, 2023
Comment on lines
+11
to
+12
| WORKFLOW: 'application/invocations+car', | ||
| RECEIPT: 'application/receipt+dag-cbor' |
There was a problem hiding this comment.
- the + suffix denotes an existing media type which are registered as
vnd.ipld.carandvnd.ipld.dag-cbor - the prefix is a tree, and we can add things to the vnd tree without much fuss like:
application/vnd.w3.ucan+vnd.ipld.car
application/vnd.w3.ucan.receipt+vnd.ipld.dag-cbor
of if we really don't care then
application/x.ucan+vnd.ipld.car
application/x.ucan.receipt+vnd.ipld.dag-cbor
There was a problem hiding this comment.
There was a problem hiding this comment.
note that our notion of an invocation is currently a short lived ucan delegation that we as a service provider choose to interpret as an invocation. they are not explicitly invocation ucans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hooks kinesis consumers with receipts, instead of previous world where it would hook up with workflows. For this, it simply filters out Kinesis events that are not receipts as they should not be account for the metrics we want to track at the moment.
As talked in today`s morning sync, setting up a new Kinesis stream so that: