Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UploadsList components #141

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Conversation

travis
Copy link
Contributor

@travis travis commented Dec 6, 2022

first pass at UploadsLists headless components. needs an example in react-ui to prove out

two main questions for reviewers:

  1. any thoughts on the API for this component? feel free to pass on evaluating this until I have an example/docs
  2. is it worth adding a "prev" function to the UploaderProvider so that we could build out a real basic "paging" component? I don't think we'll be able to add current page/total number of pages controls and indicators without more support from the backend service, but just forward and backward is better than a one way street
  3. otoh, should I maybe add an infinite scroll list component to show off what we can do with the current API?

TODO:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 6, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 40665e7:

Sandbox Source
@w3ui/example-react-file-upload Configuration
@w3ui/example-react-sign-up-in Configuration
@w3ui/example-react-uploads-list Configuration
@w3ui/example-solid-file-upload Configuration
@w3ui/example-solid-sign-up-in Configuration
@w3ui/example-solid-uploads-list Configuration
@w3ui/example-vue-file-upload Configuration
@w3ui/example-vue-sign-up-in Configuration
@w3ui/example-vue-uploads-list Configuration

first pass at UploadsLists headless components. needs an example in react-ui to prove out
@travis travis force-pushed the feat/w3ui-headless-uploads-list branch from 5a6f366 to bb9fda3 Compare December 6, 2022 20:38
the headless Uploader component changed a bit, so update for that
this demonstrates how to use the new headless components in `react-uploads-list`
@travis travis marked this pull request as ready for review December 6, 2022 21:56
@travis travis changed the title wip: UploadsList components feat: UploadsList components Dec 6, 2022
@travis
Copy link
Contributor Author

travis commented Dec 7, 2022

ok I'm going to merge this since it's a sub-PR and will get reviewed with #136 - I'm confident enough after chatting with folks about this that it's the right thing that it doesn't need a separate review

@travis travis merged commit 6dec856 into feat/w3ui-ui Dec 7, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant