Do not update filesystem info for resize in the installer mode

[vojtechtrefny]

Blivet runs update_size_info automatically in Anaconda so we don't
need to do it again. Also our update_size_info call will always
fail for LVs because they are no longer active when blivet-gui is
running (because anaconda runs teardown_all during populate).

Resolves: rhbz#1826370

[AdamWill]

I'm testing this now, but investigating independently I had come to pretty much exactly the same conclusion, and the change is more or less exactly what I was gonna propose too, so LGTM :)

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/storaged-project-blivet-gui-173
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[vojtechtrefny]

Jenkins, test this please.

[AdamWill]

Fix confirmed in testing. I'm just wondering if it might be a bit safer to do something like this:

if not self.installer_mode or not blivet_device.min_size:

just in case there's some case we've not thought of where we really do need to update the size info at this point in the installer...but it's only an idea.

[AdamWill]

eh, seems like most filesystems have default min sizes, so that's probably not going to do much.

[vojtechtrefny]

Fix confirmed in testing. I'm just wondering if it might be a bit safer to do something like this:

if not self.installer_mode or not blivet_device.min_size:

just in case there's some case we've not thought of where we really do need to update the size info at this point in the installer...but it's only an idea.

Blivet does the size info update in FS class constructor so we really shouldn't need to run it again. Anaconda (Custom partitioning) also doesn't do that. Worst case scenario: we'll mark the device as not resizable which is what's happening right now. Not ideal but not worse :-)