Do not check for "problematic" disks in ActionList._pre_process #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _find_active_devices_on_action_disks function originally prevented from making any changes on disks with active devices (active LVs, mounted partitions etc.) This was changed in b72e957 and the check currently prevents only reformatting the disklabel on such disks which should be already impossible on disks with an existing partition. The check currently also makes it impossible to add a new disk to an existing VG -- the new disk has an active device (the VG) in our storage model so creating a new partition table (even if it didn't have one before) marks it as "problematic".
vojtechtrefny
force-pushed
the
3.5-devel_disklabel-ignore-problematic-disks
branch
from
4474895
to
399e9dd
Compare
|
Jenkins, test this please. |
1 similar comment
|
Jenkins, test this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _find_active_devices_on_action_disks function originally
prevented from making any changes on disks with active devices
(active LVs, mounted partitions etc.) This was changed in
b72e957 and the check currently prevents only reformatting
the disklabel on such disks which should be already impossible
on disks with an existing partition.
The check currently also makes it impossible to add a new disk to
an existing VG -- the new disk has an active device (the VG) in
our storage model so creating a new partition table (even if it
didn't have one before) marks it as "problematic".
This is a less conservative version of #1037 removing the check completely. I mean, what could go wrong, right?