Do not report as Mactel for Apple Macs with the T2 chip
#1090
Conversation
|
Can one of the admins verify this patch? |
|
This also solves https://bugzilla.redhat.com/show_bug.cgi?id=2140462 |
|
Yeah, this looks good enough for T2-based Macs. Could you please add similar change for the T1 chip? I've had |
|
Jenkins, ok to test. |
|
The problem with how this is implemented is that any new T1 or T2 system will fall back to being treated like an old mactel system. It would be better if it detected the old ones and defaulted to the new behavior on newer systems. |
Normally this code would be a bad approach, but Apple no longer makes T2 Intel macs, so our list does not need to be updated. Apple said it will not make new Intel macs at all. |
I could not find a list of T1 macs, but if there is a list it is just a matter of adding the DMI ids to the set. EDIT: After some research, I think that T1 macs should continue to use the old |
| elif not os.path.isfile(DMI_PRODUCT_ID): | ||
| t2_mac = False | ||
| else: | ||
| buf = open(DMI_PRODUCT_ID).read() |
There was a problem hiding this comment.
Ok, we do exactly the same below with the DMI_CHASSIS_VENDOR. I guess I can fix both later in a separate PR.
There was a problem hiding this comment.
Should I leave this as is.
There was a problem hiding this comment.
Yes, I will fix this later, we have this problem at more places. I want to give some more time to other people to review this, but other than that, this is ready to be merged. Thank you again.
Fair enough, I guess the secure boot enforcement the original bugreport was about works differently than on the T2 platforms. |
Its not just that, the EFI in T1 macs will only properly honor some boot icon/name stuff on HFS+ partitions. |
T2 apple macs behave much more like normal
EFIcomputers than the current use ofMactel. This PR will make T2 Apple Macs report as x86-64 EFI computers, which is probably the right behavior. This PR also adds theis_t2mac()function to arch.py for detecting T2 macs.