Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize Makefile test targets on Python version. #151

Merged
merged 1 commit into from
Jun 9, 2015

Conversation

mulkieran
Copy link
Contributor

Check that dependencies for testing are available.

Check that dependencies for testing are available.
@mulkieran
Copy link
Contributor Author

This is a slightly amended version of #120.

The only difference is that test dependencies are stored in variable TEST_DEPENDENCIES and that sort and uniq are used to drop duplicates while non-recursive assignment is used to calculate value of TEST_DEPENDENCIES. This is marginally better because it reports all uninstalled packages in an orderly way. The upside of storing this all in a variable is that the test dependencies only need to be calculated once; the downside is that they need to be calculated at least once always.

Note that even if running tests for python 2, python 3 dependencies are checked. It's hard to get around that w/out doing something really different than grepping the spec file for '^Requires:' lines, and I'm not sure what that really different thing would be.

@atodorov
Copy link
Contributor

atodorov commented Jun 9, 2015

ack on my side.

@vpodzime
Copy link
Contributor

vpodzime commented Jun 9, 2015

Looks good to me too.

@vpodzime vpodzime added the ACK label Jun 9, 2015
mulkieran added a commit that referenced this pull request Jun 9, 2015
Parameterize Makefile test targets on Python version.
@mulkieran mulkieran merged commit 40a2d5b into storaged-project:master Jun 9, 2015
@mulkieran mulkieran deleted the master-120 branch June 9, 2015 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants