LVM cache creation #190
Merged
LVM cache creation #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpodzime
force-pushed
the
master-lvm_cache_creation
branch
from
d822463
to
6f1d19b
Compare
|
Fixed a pylint warning. |
Instead of passing cache parameters as separate numbers, strings, etc. we may better put them into objects that hold them as a single logical unit.
These are the basic building blocks for LVM cache creation as all high-level calls end up doing these things.
In order to minimize the risk of non-cached LVs taking space on fast PVs that should be used by caches.
LVM cache takes space from the VG, but it is not included in the cached LV's size.
The new LV's parent may be a VG or a thin pool depending on the type of the new LV. Let's call this object 'parent' instead of 'vg' which is way less confusing.
The requested size for the LV's non-cache part may be bigger than the free space on the slow PVs while it can safely fit in the set of slow and fast PVs together with the cache. An example of this is when a kickstart is used with two PVs in a VG and LV(s) with --cachesize and --grow. In that case the LV is grown to the maximum size filling up the VG together with the cache and other LVs (and their caches).
vpodzime
force-pushed
the
master-lvm_cache_creation
branch
from
6f1d19b
to
5512c61
Compare
|
New version using PV devices instead of just their names. |
|
Looks good to me. |
|
Some unit tests to go along with this would be really nice. |
I'll definitely implement some once this gets merged and has some "final" state. I first wanted to catch up with rhel7-branch and its support for LVM cache. Now I can work on both unit tests and kickstart tests for anaconda. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits that add support for creation of cached LVs plus two minor changes that make things a bit nicer. Please note that I'm intentionally leaving the changes in the last commit as a standalone commit as it needs some attention.