Add unit tests for the LVM cache support #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also add assert statements to some of the other lvm tests to ensure they correctly report themselves as not being cached -- maybe device_properties_test is a good place for that. |
|
That's a good point, will do. |
So that we can catch possible regressions easily in the future.
If there are no such internal LVs as some properties check, the result is sum([]), which is 0. However, these properties are supposed to return size, thus a Size instance.
We need to make sure these are all available and have proper values.
It should report it is cached with some other values reflecting the fact too.
vpodzime
force-pushed
the
master-lvm_cache_tests
branch
from
4f073e2
to
8b6bc52
Compare
|
Added one more check to the LVM cache support unit test ( |
|
Looks good to me. |
vpodzime
added a commit
that referenced
this pull request
Aug 14, 2015
Add unit tests for the LVM cache support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can catch possible regressions easily in the future.