fcoe: replace fipvlan with fcoemon (#1085325) #200
Conversation
Same as dracut (#1129888), we are moving to use fcoemon which provides more robust approach than fipvlan. Resolves: rhbz#1085325
| while timeout > 0: | ||
| rc, out = util.run_program_and_capture_output( | ||
| ["lldptool", "-p"]) | ||
| if not rc: |
There was a problem hiding this comment.
I prefer using if rc != 0 in these checks as I always has to think about it otherwise. Unless you're strongly against that, please replace these conditions with if rc != 0.
|
Looks good to me otherwise. |
| ["lldptool", "-p"]) | ||
| if not rc: | ||
| break | ||
| log.info("Waiting for lldpad to be ready") |
There was a problem hiding this comment.
these are going to clutter up the logs, maybe only log if the timeout is exceeded. while / else could be used for that.
There was a problem hiding this comment.
Yes, I am going to what you suggest, please ignore the patch added to this branch, your way is nicer.
There was a problem hiding this comment.
Ah, sorry, actually the patch added is the way I'd go, because eg if the timeout appears in 2nd wile loop, the else branches of the loop and all subsequent while loops blocks will get executed.
|
I will, thanks. |
|
Pushed so we can get as early testing as possible. I addressed these review remarks locally:
|
Same as dracut (#1129888), we are moving to use fcoemon which provides more
robust approach than fipvlan.
Resolves: rhbz#1085325