Support legacy MBR (msdos) as part of UEFI to enable hybrid builds #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests run the translation-canary test which needs the translations, so this makes sure you can pull them down for the test.
We don't want to use the information from the system the tests are running on and actually we cannot even grab that information because the tests may not be run as root. To prevent issues and exceptions, we can easily just mock all three LVM listing functions - lvs(), vgs() and pvs().
…_vgs Mock all blockdev's listing functions for populator tests
…nk_size Allow custom chunk size specification for MDRaidArrayDevice
Also remove l10n lines. (cherry picked from commit b9ec796)
(This reverts commit 495be07, which removed the nvdimm Recommends on 3.0-devel since nvdimm support does not exist on that branch.)
Spec file updates for python 2/3 and Fedora dist-git.
The UEFI spec supports legacy MBR (msdos) in section 5.2 of the UEFI 2.7 spec [1]. There's a number of use cases where we might boot on a UEFI device but want to support, but not by default, the creation of images using legacy MBR partitions. One of these use cases is cloud images where we can produce a single image tha will run on UEFI supported, including secure-boot, clouds but also support AWS which only supports MBR partitioning schemes [2] and in the current config anaconda fails the install where this is a perfectly valid and widely supported deployment mechanism. So enable the ability to use legacy msdos partitioning schemes, but don't use it for default installs, so people may consume this mechanism using kickstarts rather than having the install fail for a valid use case. [1] https://uefi.org/sites/default/files/resources/UEFI%20Spec%202_7_A%20Sept%206.pdf [2] https://docs.aws.amazon.com/vm-import/latest/userguide/vmie_prereqs.html Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
|
Can you please create a new PR against |
|
It would be useful if you'd actually document that somewhere, it would save everyone a bunch of time :) |
|
We have some documentation for contributors but it's a little bit outdated. Thank you for creating the new PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UEFI spec supports legacy MBR (msdos) in section 5.2 of the UEFI 2.7 spec [1].
There's a number of use cases where we might boot on a UEFI device but want to
support, but not by default, the creation of images using legacy MBR partitions.
One of these use cases is cloud images where we can produce a single image
tha will run on UEFI supported, including secure-boot, clouds but also
support AWS which only supports MBR partitioning schemes [2] and in the current
config anaconda fails the install where this is a perfectly valid and widely
supported deployment mechanism.
So enable the ability to use legacy msdos partitioning schemes, but don't use
it for default installs, so people may consume this mechanism using kickstarts
rather than having the install fail for a valid use case.
[1] https://uefi.org/sites/default/files/resources/UEFI%20Spec%202_7_A%20Sept%206.pdf
[2] https://docs.aws.amazon.com/vm-import/latest/userguide/vmie_prereqs.html
Signed-off-by: Peter Robinson pbrobinson@gmail.com