Do not log entire exception when trying to get ISCSI initiator name #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwlehman
approved these changes
Mar 17, 2021
We do this every time and in most cases the call will fail because there is no ISCSI firmware. Having the entire exception logged is not useful for us (it will always be the same backtrace for a failed DBus call) and it confuses users when reporting bugs because it's the first error message in the log.
vojtechtrefny
force-pushed
the
3.4-devel_iscsi-exception-log
branch
from
c07575d
to
297946b
Compare
I picked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this every time and in most cases the call will fail
because there is no ISCSI firmware. Having the entire exception
logged is not useful for us (it will always be the same backtrace
for a failed DBus call) and it confuses users when reporting bugs
because it's the first error message in the log.