Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails when libparted-dev is missing #916

Closed
mbiebl opened this issue Jun 28, 2023 · 1 comment · Fixed by #919
Closed

Build fails when libparted-dev is missing #916

mbiebl opened this issue Jun 28, 2023 · 1 comment · Fixed by #919

Comments

@mbiebl
Copy link
Contributor

mbiebl commented Jun 28, 2023

Version: 3.0

According to configure.ac, libparted is only required when building with --with-tools.
But building with --without-tools and libparted missing results in:

libtool: compile:  gcc -DPACKAGE_NAME=\"libblockdev\" -DPACKAGE_TARNAME=\"libblockdev\" -DPACKAGE_VERSION=\"3.0\" "-DPACKAGE_STRING=\"libblockdev 3.0\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"https://github.com/storaged-project/libblockdev\" -DPACKAGE=\"libblockdev\" -DVERSION=\"3.0\" -DNDEBUG=1 -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_DLFCN_H=1 -DHAVE_STRING_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_FCNTL_H=1 -DHAVE_SYS_IOCTL_H=1 -DHAVE_LINUX_RANDOM_H=1 -DHAVE_GLOB_H=1 -DHAVE_SYSLOG_H=1 -DHAVE_MATH_H=1 "-DWITH_BD_ESCROW=/**/" "-DWITH_BD_BTRFS=/**/" "-DWITH_BD_CRYPTO=/**/" "-DWITH_BD_DM=/**/" "-DWITH_BD_LOOP=/**/" "-DWITH_BD_LVM=/**/" "-DWITH_BD_LVM_DBUS=/**/" "-DWITH_BD_MDRAID=/**/" "-DWITH_BD_MPATH=/**/" "-DWITH_BD_SWAP=/**/" "-DWITH_BD_PART=/**/" "-DWITH_BD_FS=/**/" "-DWITH_BD_NVDIMM=/**/" -DLIBCRYPTSETUP_24=1 -DLIBCRYPTSETUP_26=1 -DLIBMOUNT_NEW_ERR_API=1 -DLIBNDCTL_NEW_MODES=1 -I. -I./../../include/ -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/libmount -I/usr/include/blkid -Wall -Wextra -Werror -g -O2 -ffile-prefix-map=/home/michael/debian/build-area/libblockdev-3.0=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu99 -c lvm-dbus.c  -fPIC -DPIC -o .libs/libbd_lvm_dbus_la-lvm-dbus.o
vdo_stats.c:21:10: fatal error: parted/parted.h: No such file or directory
   21 | #include <parted/parted.h>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.

See

src/plugins/vdo_stats.c:#include <parted/parted.h>

I do not immediately see, where src/plugins/vdo_stats.c requires libparted, so maybe this is just a leftover.

@mbiebl mbiebl changed the title Build fails when libparted-dev Build fails when libparted-dev is missing Jun 28, 2023
vojtechtrefny added a commit to vojtechtrefny/libblockdev that referenced this issue Jun 29, 2023
I have no idea where this came from, but we don't need (and never
did) libparted in vdo_stats.

Fixes: storaged-project#916
@tbzatek
Copy link
Member

tbzatek commented Jun 29, 2023

Related: dosfstools/dosfstools#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants