core: Add o.fd.U.Filesystem.Size property #477
Conversation
|
I am still working on this, but this is a good preview, I think. Wdyt? |
I think you should use [libblockdev] (http://storaged.org/libblockdev/libblockdev-FS.html) here and store the info just in UDisks not in udev. |
Makes sense, thanks! |
mvollmer
changed the title
|
Rewritten with libblockdev, tests added. |
|
Jenkins, ok to test. |
| disk.Resize(dbus.UInt64(size // 2), self.no_options, dbus_interface=self.iface_prefix + '.Filesystem') | ||
| self.assertTrue(disk.Check(self.no_options, dbus_interface=self.iface_prefix + '.Filesystem')) | ||
| self.get_property(disk, '.Filesystem', 'Size').assertEqual(size // 2) | ||
|
|
||
| def test_size(self): |
There was a problem hiding this comment.
Please skip this test for unsupported filesystems and filesystems that can't be created and/or mounted (see _can_create and _can_mount in other tests).
Also please "skip" this test for the FailsystemTestCase.
There was a problem hiding this comment.
No, not yet. I forgot that we only report this for ext and xfs... that's what you meant with "unsupported", obviously.
There was a problem hiding this comment.
Should be done now. There are test failures, but I think they are unrelated, no?
There was a problem hiding this comment.
Yes, the failures definitely look unrelated. Thanks.
This allows the client to detect filesystems that could be resized to fill more of their block device.
This allows the client to detect filesystems that could be resized to
fill more of their block device.