When mounts is empty, skip the file system size check #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e check If mounts is empty (the disk is not mounted), skip the file system size check to prevent the "size" from being unable to be obtained immediately when the disk is performing other operations (such as formatting), causing the udisks process to wait for a long time. Signed-off-by: changlianzhi <changlianzhi@uniontech.com>
HeroesLoveToRoujiamo
changed the title
|
Can one of the admins verify this patch? |
tbzatek
requested changes
Mar 31, 2021
There was a problem hiding this comment.
The org.freedesktop.UDisks2.Filesystem.Size property is supposed to be available also on non-mounted filesystem.
We've been fighting with updates of this property for a long time since it involves calling an external tool. Unfortunately it's already part of a public API and can't be changed like this.
|
New commit: #873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If mounts is empty (the disk is not mounted), skip the file system size check
to prevent the "size" from being unable to be obtained immediately when the
disk is performing other operations (such as formatting), causing the udisks
process to wait for a long time. #871
Signed-off-by: changlianzhi changlianzhi@uniontech.com