udiskslinuxfilesystem: Make 'size' property retrieval on demand #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbzatek
changed the title
This was referenced Jan 6, 2022
Filesystem size value retrieval is very expensive as it typically calls filesystem tools that read superblock -> doing some I/O. Other filesystem properties are typically retrieved from existing stateful sources, either udev or sysfs. This change overrides the gdbus-codegen-generated GDBusInterfaceSkeleton property retrieval and adds a custom hook that retrieves the filesystem size value when actually requested. One limitation of such approach is that the hook is called with the GDBusObjectManager lock held and thus it needs to be as minimal as possible and avoiding access to any GDBusObject.
|
I think we have some more "expensive" properties in the encrypted interface, it might be worth changing these too. |
Hmm, there might be other candidates, might be interesting to revise all properties (except for modules perhaps) in all interfaces. However this is kind of experiment and a hack for the time being, let's see if this way proves itself over time with continuous testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filesystem size value retrieval is very expensive as it typically calls
filesystem tools that read superblock -> doing some I/O. Other
filesystem properties are typically retrieved from existing stateful
sources, either udev or sysfs.
This change overrides the gdbus-codegen-generated GDBusInterfaceSkeleton
property retrieval and adds a custom hook that retrieves the filesystem
size value when actually requested.
One limitation of such approach is that the hook is called with
the GDBusObjectManager lock held and thus the hook needs to be as minimal
as possible and needs to avoid any access to any GDBusObject.
TODO: handle ATA power management.
Fixes #946
Fixes #911
Fixes #871
Fixes #868