Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove chakra dependency #3

Merged
merged 5 commits into from
Sep 23, 2021
Merged

Conversation

MarceloAlves
Copy link
Member

Removing the need to depend on Chakra UI

image

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 23, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bd48ad3:

Sandbox Source
msw-toolbar-template Configuration

@msutkowski
Copy link
Member

@MarceloAlves I think dropping the test would solve this 🤣. Being that the test doesn't do anything, and we can't test setupWorker in node... we'd only be able to really test implementation details of msw after mocking it, which I don't think is really worthwhile. We could test the initial state of things and localStorage, but again, I don't think it's worth it. I'd vote for 💣 ing the test unless you have a different idea.

@msutkowski msutkowski merged commit 2d6382f into main Sep 23, 2021
@msutkowski msutkowski deleted the marceloalves/remove-chakra-dep branch September 23, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants