Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed lazy loading of the images #171

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Fixed lazy loading of the images #171

merged 2 commits into from
Mar 15, 2021

Conversation

Kassares
Copy link
Contributor

No description provided.

@dijs
Copy link
Contributor

dijs commented Mar 12, 2021

@Kassares Do you know why the test is not running?

@Kassares
Copy link
Contributor Author

@dijs unfortunately, no, let me run test for lazyLoadImages.js locally

@Kassares
Copy link
Contributor Author

@dijs I've fixed one issue with lazyLoadImages.js, it was one test fail. But I see a lot of fails in other files. Could you check?

@dijs
Copy link
Contributor

dijs commented Mar 12, 2021

@Kassares I am confused why the github test action is not working. Do you see any results on your end?

@dijs dijs merged commit a980053 into storefront-foundation:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dijs dijs dijs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kassares @dijs