Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local RPMs: Replace QtSparql with QtDocGallery #462

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

citronalco
Copy link
Contributor

@citronalco citronalco commented Mar 14, 2024

libqtsparql's QML API was dropped from Sailfish OS 4.5.0.

Fixes #461.

@Olf0
Copy link
Member

Olf0 commented Mar 15, 2024

@citronalco, thank you very much for posing this PR #462! AFAICT, this is looking good. I suppose you have started the resulting binary and a quick test has shown the "Local RPM files" page to work well?

@Olf0 Olf0 self-assigned this Mar 15, 2024
@Olf0
Copy link
Member

Olf0 commented Mar 15, 2024

Moved @citronalco's reply, because I moved the question from #461 to here (#462):

It works at least in Sailfish OS 4.5 and 3.4. Tested that in the emulator VMs provided by the SDK.

Copy link
Member

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Olf0 Olf0 merged commit fdd9c5b into storeman-developers:devel Mar 18, 2024
1 check passed
Olf0 added a commit that referenced this pull request Mar 18, 2024
* [harbour-storeman.changes] Add second record

* [build-devel.yml] Beautify

* [build-sfos3.1.yml] Beautify

* [build-sfos3.3.yml] Beautify

* [build-sfos4.2.yml] Beautify

* [build-sfos4.2_latest.yml] Beautify

* [build-sfos4.2_latest.yml] Add "+"

* [harbour-storeman.spec] Use `%{name}` even more

* [README.md] Enhance link

* [README.md] Simplify

* [translations/README.md] Remove stray space character

* [README.md] Enhance table of screenshots

* [README.md] Improve picture descriptions

* [README.md] Fix table rendering by inserting ` '`s

* [Update README.md] Final screenshots-table formatting fix-up …

…, hopefully.

* [README.md] Prefix latest release version image with `Current`

* [README.md] Use relative image links

* [harbour-storeman.qml] Fix typo in comment

* [README.md] "e.g.", instead of "e.g.,"

* [README.md] Update to current version from FlowPlayer

* Local RPMs: Replace QTSparql with QtDocGallery (#462)

Because libqtsparql's QML API was dropped from Sailfish OS 4.5.0.

* [harbour-storeman.changes] Update for v0.3.8 (#464)

* Add citronalco to contributors (#466)

* [README.md] Add citronalco to contributors

* [LICENSE] Add citronalco to contributors

* [DevelopersModel.qml] Add citronalco to contributors

---------

Co-authored-by: citronalco <2651739+citronalco@users.noreply.github.com>
Olf0 added a commit that referenced this pull request Mar 18, 2024
…lect RPM files … (#463)

[LocalRpmsPage.qml] Filter for `mimeType` instead of `fileName` as [suggested by @pvuorela](#461 (comment)). Enhances PR #462, which closed issue #461.
Olf0 added a commit that referenced this pull request Mar 18, 2024
…463) (#470)

… select RPM files, as [suggested by @pvuorela](#461 (comment)). Enhances PR #462, which closed issue #461.
@Olf0 Olf0 changed the title Local RPMs: Replace QTSparql with QtDocGallery Local RPMs: Replace QtSparql with QtDocGallery Mar 19, 2024
Olf0 added a commit that referenced this pull request Mar 19, 2024
* [harbour-storeman.changes] Add second record

* [build-devel.yml] Beautify

* [build-sfos3.1.yml] Beautify

* [build-sfos3.3.yml] Beautify

* [build-sfos4.2.yml] Beautify

* [build-sfos4.2_latest.yml] Beautify

* [build-sfos4.2_latest.yml] Add "+"

* [harbour-storeman.spec] Use `%{name}` even more

* [README.md] Enhance link

* [README.md] Simplify

* [translations/README.md] Remove stray space character

* [README.md] Enhance table of screenshots

* [README.md] Improve picture descriptions

* [README.md] Fix table rendering by inserting `&nbsp;'`s

* [Update README.md] Final screenshots-table formatting fix-up …

…, hopefully.

* [README.md] Prefix latest release version image with `Current`

* [README.md] Use relative image links

* [harbour-storeman.qml] Fix typo in comment

* [README.md] "e.g.", instead of "e.g.,"

* [README.md] Update to current version from FlowPlayer

* Local RPMs: Replace QTSparql with QtDocGallery (#462)

Because libqtsparql's QML API was dropped from Sailfish OS 4.5.0.

* [harbour-storeman.changes] Update for v0.3.8 (#464)

* Add citronalco to contributors (#466)

* [README.md] Add citronalco to contributors

* [LICENSE] Add citronalco to contributors

* [DevelopersModel.qml] Add citronalco to contributors

* [LocalRpmsPage.qml] Filter for `mimeType` instead of `fileName` to select RPM files … (#463)

[LocalRpmsPage.qml] Filter for `mimeType` instead of `fileName` as [suggested by @pvuorela](#461 (comment)). Enhances PR #462, which closed issue #461.

* [harbour-storeman.changes] Update with final PR for 0.3.8-release1

---------

Co-authored-by: citronalco <2651739+citronalco@users.noreply.github.com>
Olf0 added a commit that referenced this pull request Mar 19, 2024
* [harbour-storeman.changes] Add second record

* [build-devel.yml] Beautify

* [build-sfos3.1.yml] Beautify

* [build-sfos3.3.yml] Beautify

* [build-sfos4.2.yml] Beautify

* [build-sfos4.2_latest.yml] Beautify

* [build-sfos4.2_latest.yml] Add "+"

* [harbour-storeman.spec] Use `%{name}` even more

* [README.md] Enhance link

* [README.md] Simplify

* [translations/README.md] Remove stray space character

* [README.md] Enhance table of screenshots

* [README.md] Improve picture descriptions

* [README.md] Fix table rendering by inserting `&nbsp;'`s

* [Update README.md] Final screenshots-table formatting fix-up …

…, hopefully.

* [README.md] Prefix latest release version image with `Current`

* [README.md] Use relative image links

* [harbour-storeman.qml] Fix typo in comment

* [README.md] "e.g.", instead of "e.g.,"

* [README.md] Update to current version from FlowPlayer

* Local RPMs: Replace QTSparql with QtDocGallery (#462)

Because libqtsparql's QML API was dropped from Sailfish OS 4.5.0.

* [harbour-storeman.changes] Update for v0.3.8 (#464)

* Add citronalco to contributors (#466)

* [README.md] Add citronalco to contributors

* [LICENSE] Add citronalco to contributors

* [DevelopersModel.qml] Add citronalco to contributors

* [LocalRpmsPage.qml] Filter for `mimeType` instead of `fileName` to select RPM files … (#463)

[LocalRpmsPage.qml] Filter for `mimeType` instead of `fileName` as [suggested by @pvuorela](#461 (comment)). Enhances PR #462, which closed issue #461.

* [harbour-storeman.changes] Update with final PR for 0.3.8-release1

---------

Co-authored-by: citronalco <2651739+citronalco@users.noreply.github.com>
Olf0 added a commit that referenced this pull request Mar 19, 2024
* [harbour-storeman.changes] Add second record

* [build-devel.yml] Beautify

* [build-sfos3.1.yml] Beautify

* [build-sfos3.3.yml] Beautify

* [build-sfos4.2.yml] Beautify

* [build-sfos4.2_latest.yml] Beautify

* [build-sfos4.2_latest.yml] Add "+"

* [harbour-storeman.spec] Use `%{name}` even more

* [README.md] Enhance link

* [README.md] Simplify

* [translations/README.md] Remove stray space character

* [README.md] Enhance table of screenshots

* [README.md] Improve picture descriptions

* [README.md] Fix table rendering by inserting `&nbsp;'`s

* [Update README.md] Final screenshots-table formatting fix-up …

…, hopefully.

* [README.md] Prefix latest release version image with `Current`

* [README.md] Use relative image links

* [harbour-storeman.qml] Fix typo in comment

* [README.md] "e.g.", instead of "e.g.,"

* [README.md] Update to current version from FlowPlayer

* Local RPMs: Replace QTSparql with QtDocGallery (#462)

Because libqtsparql's QML API was dropped from Sailfish OS 4.5.0.

* [harbour-storeman.changes] Update for v0.3.8 (#464)

* Add citronalco to contributors (#466)

* [README.md] Add citronalco to contributors

* [LICENSE] Add citronalco to contributors

* [DevelopersModel.qml] Add citronalco to contributors

* [LocalRpmsPage.qml] Filter for `mimeType` instead of `fileName` to select RPM files … (#463)

[LocalRpmsPage.qml] Filter for `mimeType` instead of `fileName` as [suggested by @pvuorela](#461 (comment)). Enhances PR #462, which closed issue #461.

* [harbour-storeman.changes] Update with final PR for 0.3.8-release1

---------

Co-authored-by: citronalco <2651739+citronalco@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Page "Local RPM files" does no longer work
2 participants