StorageAdapter tests are now skipped if required environment variable…

…s to not exist
storeman-io · Jul 17, 2018 · 4f6bd42 · 4f6bd42
1 parent 1f24d12
commit 4f6bd42
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/tests/StorageAdapter/AbstractStorageAdapterTest.php b/tests/StorageAdapter/AbstractStorageAdapterTest.php
@@ -9,7 +9,10 @@ abstract class AbstractStorageAdapterTest extends TestCase
 {
     public function testRoundtrip()
     {
-        $adapter = $this->getStorageAdapter();
+        if (($adapter = $this->getStorageAdapter()) === null)
+        {
+            return;
+        }
 
         $objectName = uniqid('test_file_');
         $objectData = random_bytes(rand(10, 100));

diff --git a/tests/StorageAdapter/FtpTest.php b/tests/StorageAdapter/FtpTest.php
@@ -13,12 +13,18 @@ class FtpTest extends AbstractStorageAdapterTest
 
     protected function getStorageAdapter(): StorageAdapterInterface
     {
+        if (!getenv('ftpHost') || !getenv('ftpUser') || !getenv('ftpPass'))
+        {
+            $this->markTestSkipped('Skipping test because required environment variables do not exist.');
+
+            return null;
+        }
+
         $vaultConfiguration = new VaultConfiguration($this->getConfigurationMock());
         $vaultConfiguration->setSettings([
-            // https://dlptest.com/ftp-test/
-            'host' => 'ftp.dlptest.com',
-            'username' => 'dlpuser@dlptest.com',
-            'password' => '3D6XZV9MKdhM5fF',
+            'host' => getenv('ftpHost'),
+            'username' => getenv('ftpUser'),
+            'password' => getenv('ftpPass'),
         ]);
 
         return new Ftp($vaultConfiguration);

diff --git a/tests/StorageAdapter/S3Test.php b/tests/StorageAdapter/S3Test.php
@@ -13,6 +13,13 @@ class S3Test extends AbstractStorageAdapterTest
 
     protected function getStorageAdapter(): StorageAdapterInterface
     {
+        if (!getenv('s3key') || !getenv('s3bucket') || !getenv('s3region'))
+        {
+            $this->markTestSkipped('Skipping test because required environment variables do not exist.');
+
+            return null;
+        }
+
         $vaultConfiguration = new VaultConfiguration($this->getConfigurationMock());
         $vaultConfiguration->setSettings([
             'key' => getenv('s3key'),