Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code constants on SQLErrors #870

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add code constants on SQLErrors #870

wants to merge 1 commit into from

Conversation

thgreasi
Copy link

No description provided.

brodybits
brodybits requested changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@brodybits brodybits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thgreasi for the contribution and please accept my apologies for the extra-long delay.

I will not very likely merge this proposal since I am planning to remove the numerical code member from the error object.

In case I would accept this update, there are a couple more blockers:

  • the plugin JavaScript is still generated from CoffeeScript
  • test updates would be needed to help ensure this does not get broken someday in the future

@thgreasi
Copy link
Author

thgreasi commented Dec 8, 2019

Oh, I didn't realize that the SQLitePlugin.coffee.md was the src of this.
Will do, thanks for the hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brodybits brodybits brodybits requested changes

Assignees
No one assigned
Labels
enhancement testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thgreasi @brodybits