Add check for missing shard

storj-archived · Apr 26, 2017 · 5a5e2a9 · 5a5e2a9
1 parent 72464e1
commit 5a5e2a9
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 0 deletions.
diff --git a/lib/bridge-client/index.js b/lib/bridge-client/index.js
@@ -1056,6 +1056,14 @@ BridgeClient.prototype.createFileStream = function(bucket, file, opt, cb) {
         return done(err);
       }
 
+      // When erasure encoding is implemented, this can just
+      // become a missing shard that is recovered.
+      for (var i = 0; i < pointers.length; i++) {
+        if (!pointers[i].farmer) {
+          return done(new Error('Missing shard'));
+        }
+      }
+
       skip += limit;
       done(null, pointers);
     });

diff --git a/test/bridge-client/index.unit.js b/test/bridge-client/index.unit.js
@@ -1253,6 +1253,51 @@ describe('BridgeClient', function() {
         });
       });
 
+      it('should error if farmer is missing to download', function(done) {
+        var client = new BridgeClient();
+        var _getFilePointers = sinon.stub(
+          client,
+          'getFilePointers'
+        );
+        _getFilePointers.onFirstCall().callsArgWith(1, null, [
+          {
+            size: 512,
+            farmer: {
+              address: '127.0.0.1',
+              port: 8080,
+              nodeID: utils.rmd160('nodeid')
+            }
+          },
+          {
+            size: 512,
+          }
+        ]);
+        _getFilePointers.onSecondCall().callsArgWith(1, null, [
+          {
+            size: 512,
+            farmer: {
+              address: '127.0.0.1',
+              port: 8080,
+              nodeID: utils.rmd160('nodeid')
+            }
+          }
+        ]);
+        sinon.stub(client, 'getFileInfo').callsArgWith(2, null, {
+          size: 512 * 3
+        });
+        _getFilePointers.onThirdCall().callsArgWith(1, null, []);
+        var _createToken = sinon.stub(
+          client,
+          'createToken'
+        ).callsArgWith(2, null, 'token');
+        client.createFileStream('bucket', 'file', {}, function(err) {
+          _createToken.restore();
+          _getFilePointers.restore();
+          expect(err.message).to.equal('Missing shard');
+          done();
+        });
+      });
+
       it('should emit stream error if slice cannot get token', function(done) {
         var client = new BridgeClient();
         var _getFilePointers = sinon.stub(