This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
Remove use of bucket token when downloading #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces the overall requests to the bridge by around 1/3 when downloading files.
braydonf
changed the title
To help improve the timeout rate for this request. Setting a timeout to 20 seconds will often result in the client closing the connection before the request can be made, a timeout of 60 seconds does not have this issue. If we reduce the number of pointers that need to be requested, there are less requests that need to be made to the network.
braydonf
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the overall requests to the bridge by around 1/3 when downloading files.
And decreases the limit from 6 to 3 pointers per request to improve timeouts when API requests are set to timeout in 20 seconds instead of 60 seconds.
Closes: #340
Depends: storj-archived/bridge#452