jenkins: fix cleanup permission issue #19
Conversation
Erikvv
force-pushed
the
jenkins-cleanup-permission
branch
30 times, most recently
from
a183af9
to
4f22f62
Compare
Erikvv
force-pushed
the
jenkins-cleanup-permission
branch
7 times, most recently
from
2d8d1ea
to
ecebe21
Compare
Erikvv
changed the title
Erikvv
force-pushed
the
jenkins-cleanup-permission
branch
from
ecebe21
to
bd869c1
Compare
|
@halkyon I wanted to suggest you as reviewer but you're not in the storj-thirdparty org |
Erikvv
force-pushed
the
jenkins-cleanup-permission
branch
from
bd869c1
to
afe0189
Compare
Replace build.sh script by Makefile (god help us) so part of it can be run on a different platform or container. The new release contains 2 binaries, one for each of the supported platforms. I tested this on a Dragonboard 410c.
Erikvv
force-pushed
the
jenkins-cleanup-permission
branch
from
afe0189
to
976f383
Compare
| } | ||
| post { | ||
| always { | ||
| cleanWs() |
There was a problem hiding this comment.
post code isn't guaranteed to run due to issues within Jenkins
There was a problem hiding this comment.
Stefan showed me that cleanup is done by https://plugins.jenkins.io/resource-disposer/ but this fails and he has to do it manually, so therefor this PR exists.
What do you suggest? I don't see harm in leaving cleanWs() here.
There was a problem hiding this comment.
storj/storj does a delete before running: https://github.com/storj/storj/blob/main/Jenkinsfile.public#L23
There was a problem hiding this comment.
storj/storj is forced to do that, because it leaves behind files in the workspace with root owner, which can only be removed by the root user.
After this PR uplink-php doesn't have that problem. Normal cleanup should work.
There was a problem hiding this comment.
The cleanup failed due to a timeout / jenkins crash not due to the permissions part.
Don't run commands as root so cleanup can take place.
On top of #14 to preempt conflicts.
Fixes #17