Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dlm/version config #2

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Dlm/version config #2

merged 2 commits into from
Oct 2, 2023

Conversation

dlamarmorgan
Copy link
Contributor

Create the design doc for bucket level object versioning configuration.

This starts the review iteration process.

Copy link
Member

@ifraixedes ifraixedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read https://docs.google.com/document/d/1AMWDRncVsCUXBp1Sqk6uHibcM6omhdRwtNtJfr3cpDc/edit?pli=1#heading=h.a5g1c8b5x9f1

Is this document finalized or more information is going to be added from the Google docs draft?

Copy link
Member

@egonelbre egonelbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few notes, but otherwise looks good

@ifraixedes
Copy link
Member

It looks good to me, however, I'd like to expose the directory organization of this repository in today's stand-up. I'll approve after it.

@ifraixedes ifraixedes self-requested a review September 22, 2023 13:24
Copy link
Member

@ifraixedes ifraixedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some conventions that we apply to these documents were merged yesterday, so please apply them before merging them.

https://github.com/storj/design-docs#conventions

@dlamarmorgan dlamarmorgan merged commit 39e5947 into main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants