-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Error Pages - Reduce content size #361
Comments
Change pkg/linksharing/sharing: optimize 429 responses mentions this issue. |
Change pkg/linksharing/web: serve bootstrap from CDN mentions this issue. |
Should we keep this open for a few more improvements? The static background could be another thing to optimize. @amwolff, did you intend for it to close after that change? |
Updates #361 Change-Id: I1e1bc22f2773fcbe516b77c55836991811b23540
Are we missing caching headers for the content? I don't see a reason why they should be such a big impact. Also, are we missing compression for the assets? |
Few other points mentioned in a Slack thread:
See the PageSpeed report here: https://pagespeed.web.dev/analysis/https-link-storjshare-io-s-jwur4oa5atf5ireddlrxtk4g7yqq-uptime-checks-hello-world-txt/kny8inzxcm?form_factor=mobile Generally it might be good to check out the network tab in the browser and see if we can spot anything else that looks like a big download or not optimal. |
Change pkg/linksharing: enable caching for static files mentions this issue. |
I found https://github.com/vearutop/statigz that looked good, but it didn't have cache busting features. Egon had a great idea (thanks!), that looks something like this:
|
This change turns on Cache-Control header for static file responses with a very long age. It also appends a version hash to static file requests from the HTML so caches are refreshed on new releases. Updates #361 Change-Id: Id748fd636e0e24654c4e5ec703bcbc02ccaa70c1
@boshevski - let's take a look at the Linksharing UI and discuss if it needs a refresh to make it more consistent with the Satellite UI. |
@ferristocrat I made a pr that optimizes the logo and the background image 3x. I'm working on updating the ui designs next |
AFAIK, #361 (comment) has not yet been implemented or will that be handled in a separate issue? |
yes, this isn't complete. I reopened it. |
Summary
Acceptance Criteria
Possible Solutions
The text was updated successfully, but these errors were encountered: