Skip to content

Commit

Permalink
Jenkinsfile.public: re-enable satellite UI tests (#6901)
Browse files Browse the repository at this point in the history
These were previously removed due to flakiness/unreliability. The tests
are being added back for a few reasons:
* updates have been made to `make test-satellite-ui` to avoid caching,
  which was causing flakiness
* there is no clear evidence that the Github failures in the past were
  Github-specific, and UI tests on Gerrit have been passing consistently
  for several weeks (Jenkinsfile.verify)
* We need to execute satellite UI tests in Jenkinsfile.public to proceed
  with more ambitious goals in the future, such as continuous deployment
  of the UI
  • Loading branch information
mobyvb committed Apr 19, 2024
1 parent 3fc56e8 commit 1cfb8d2
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 5 deletions.
22 changes: 22 additions & 0 deletions Jenkinsfile.public
Expand Up @@ -121,6 +121,7 @@ pipeline {
stage('licenses check') {
steps {
// go-licenses by default has AGPL3 in the forbidden list, hence we need to explicitly allow `storj.io/storj`.
// note: json-iterator is replaced by our stub, it should be ignored as storj.io/storj.
sh 'go-licenses check --ignore "storj.io/storj" --ignore "github.com/json-iterator/go" ./...'
}
}
Expand Down Expand Up @@ -177,6 +178,27 @@ pipeline {
}
}

stage('Satellite UI Tests') {
environment {
STORJ_TEST_COCKROACH = 'cockroach://root@localhost:26256/uitestcockroach?sslmode=disable'
STORJ_TEST_COCKROACH_NODROP = 'true'
STORJ_TEST_POSTGRES = 'omit'
STORJ_TEST_LOG_LEVEL = 'debug'
}

steps {
sh 'cockroach sql --insecure --host=localhost:26256 -e \'create database uitestcockroach;\''
sh 'make test-satellite-ui'
}

post {
failure {
sh script: 'tar -zcvf .build/test-results.tar.gz ./testsuite/playwright-ui/test-results/'
archiveArtifacts artifacts: '.build/test-results.tar.gz'
}
}
}

stage('Check Benchmark') {
environment {
STORJ_TEST_COCKROACH = 'omit'
Expand Down
6 changes: 2 additions & 4 deletions Makefile
Expand Up @@ -226,13 +226,11 @@ test-satellite-ui: ## Run playwright ui tests
npm run build;

cd testsuite/playwright-ui;\
npm install;\
npx playwright install;\
npx playwright install-deps;\
npm ci;\
npx playwright install --with-deps;\
STORJ_TEST_SATELLITE_WEB='../../web/satellite' \
go test ./... -run TestRun -count 1


.PHONY: check-monitoring
check-monitoring: ## Check for locked monkit calls that have changed
@echo "Running ${@}"
Expand Down
2 changes: 1 addition & 1 deletion testsuite/playwright-ui/playwright.config.ts
Expand Up @@ -97,7 +97,7 @@ export default defineConfig({
['dot'],
['html'],
],
retries: process.env.CI ? 1 : 0, // Retry on CI only.
retries: process.env.CI ? 2 : 0, // Retry on CI only.
testDir: './tests', // Directory where tests are located.
timeout: 30 * 1000, // Maximum time one test can run for.
use: {
Expand Down

0 comments on commit 1cfb8d2

Please sign in to comment.