Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkinsfile.public: re-enable satellite UI tests #6901

Merged
merged 12 commits into from
Apr 19, 2024
Merged

Jenkinsfile.public: re-enable satellite UI tests #6901

merged 12 commits into from
Apr 19, 2024

Conversation

mobyvb
Copy link
Member

@mobyvb mobyvb commented Apr 9, 2024

These were previously removed due to flakiness/unreliability. The tests are being added back for a few reasons:

  • updates have been made to make test-satellite-ui to avoid caching, which was causing flakiness
  • there is no clear evidence that the Github failures in the past were Github-specific, and UI tests on Gerrit have been passing consistently for several weeks (Jenkinsfile.verify)
  • We need to execute satellite UI tests in Jenkinsfile.public to prevent ui-test-breaking changes merged via Github PRs

Change-Id: I71ca6e0bf4c98f7b929e54db405196245324010a

What:

Why:

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

These were previously removed due to flakiness/unreliability. The tests
are being added back for a few reasons:
* updates have been made to `make test-satellite-ui` to avoid caching,
  which was causing flakiness
* there is no clear evidence that the Github failures in the past were
  Github-specific, and UI tests on Gerrit have been passing consistently
  for several weeks (Jenkinsfile.verify)
* We need to execute satellite UI tests in Jenkinsfile.public to proceed
  with more ambitious goals in the future, such as continuous deployment
  of the UI

Change-Id: I71ca6e0bf4c98f7b929e54db405196245324010a
@cla-bot cla-bot bot added the cla-signed label Apr 9, 2024
Change-Id: I70fb3a4b0fa20d5af6ae02e3c8020e7859d5d857
Change-Id: Ice6b61fe23e0cbb9f20a3b333131f5bba242a9f1
Change-Id: I420a0ebdd07dbd461107b7f1803b0cce56e85d79
VitaliiShpital
VitaliiShpital previously approved these changes Apr 16, 2024
ifraixedes
ifraixedes previously approved these changes Apr 18, 2024
Change-Id: I6fca8a8dce44aa2f0bcc9e31a6ee4398c8bf4dff
Change-Id: I32a9cb3f50713889135a23dc4271783340ddc2bd
@mobyvb mobyvb dismissed stale reviews from VitaliiShpital and ifraixedes via dc801a1 April 18, 2024 19:17
Change-Id: If20301c4885e38ddc3734e5e63cdbf7cfc9cf976
Change-Id: I8fbcedba5f9d23a3c43abce3cbb204bb2b2c82c6
@mobyvb mobyvb merged commit 1cfb8d2 into main Apr 19, 2024
2 checks passed
@mobyvb mobyvb deleted the mvb/uitests branch April 19, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants