-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkinsfile.public: re-enable satellite UI tests #6901
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were previously removed due to flakiness/unreliability. The tests are being added back for a few reasons: * updates have been made to `make test-satellite-ui` to avoid caching, which was causing flakiness * there is no clear evidence that the Github failures in the past were Github-specific, and UI tests on Gerrit have been passing consistently for several weeks (Jenkinsfile.verify) * We need to execute satellite UI tests in Jenkinsfile.public to proceed with more ambitious goals in the future, such as continuous deployment of the UI Change-Id: I71ca6e0bf4c98f7b929e54db405196245324010a
Change-Id: I70fb3a4b0fa20d5af6ae02e3c8020e7859d5d857
Change-Id: Ice6b61fe23e0cbb9f20a3b333131f5bba242a9f1
Change-Id: I420a0ebdd07dbd461107b7f1803b0cce56e85d79
VitaliiShpital
previously approved these changes
Apr 16, 2024
ifraixedes
previously approved these changes
Apr 18, 2024
Change-Id: I6fca8a8dce44aa2f0bcc9e31a6ee4398c8bf4dff
Change-Id: I32a9cb3f50713889135a23dc4271783340ddc2bd
Change-Id: If20301c4885e38ddc3734e5e63cdbf7cfc9cf976
Change-Id: I8fbcedba5f9d23a3c43abce3cbb204bb2b2c82c6
VitaliiShpital
approved these changes
Apr 19, 2024
ifraixedes
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were previously removed due to flakiness/unreliability. The tests are being added back for a few reasons:
make test-satellite-ui
to avoid caching, which was causing flakinessChange-Id: I71ca6e0bf4c98f7b929e54db405196245324010a
What:
Why:
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)