-
Notifications
You must be signed in to change notification settings - Fork 387
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
satellite/repair: don't remove expired segments from repair queue
It's impossible to time correctly this check. The segment may expire just at the time we upload the repaired pieces to new storage nodes. They will reject this as expired and the repair will fail. Also, we penalize storage nodes with audit failure only if they fail piece hash verification, i.e. return incorrect data, but only if they have already deleted the piece. So, it would be best if the repair service does not care about object expiration at all. This is a responsibility of another service. Removing this check will also simplify how we migrate this code correctly to the metabase. Change-Id: I09f7b372ae2602daee919a8a73cd0475fb263cd2
- Loading branch information
1 parent
22bc69a
commit 339d121
Showing
3 changed files
with
3 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters