Skip to content

Commit

Permalink
storagenode/retain: don't quit on error
Browse files Browse the repository at this point in the history
It has been noted in the forum that, during a Retain operation, when a
piece can't be deleted, the process never completes. The error is
written to the log, but the completion line "Moved pieces to trash
during retain" never is.

This `return` line is the reason. We should instead continue the loop.

Change-Id: I0f51d34aba0e81ad60a75802069b42dc135ad907
Refs: #6482
  • Loading branch information
thepaul committed Nov 6, 2023
1 parent 015cb94 commit fd55dad
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion storagenode/retain/retain.go
Expand Up @@ -343,7 +343,7 @@ func (s *Service) retainPieces(ctx context.Context, req Request) (err error) {
zap.Stringer("Satellite ID", satelliteID),
zap.Stringer("Piece ID", pieceID),
zap.Error(err))
return nil
continue
}
}
numDeleted++
Expand Down

0 comments on commit fd55dad

Please sign in to comment.